New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace explicit STDIN read with prompt () in Makefile.PL #5

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@openstrike

openstrike commented Sep 14, 2018

CPANTS recommends the use of the prompt function in preference to explicit reading from STDIN in Makefile.PL. In implementing this I've slightly restructured the logic of that section of the script to take advantage of the inherent features of prompt(). It works fine on my non-MSWin32 systems but since you previously had an explicit check for that O/S it may have some implications of which I am unaware. If you have access to MSWin32 please test it there before merging. Thanks.

This work was done as part of the CPAN PR Challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment