fix: align fast-xml-parser Deno import with package.json (HOTFIX)#102
Merged
Conversation
#100 bumped fast-xml-parser to 5.8.0 in package.json (security fix) but Renovate cannot see the explicit @5.0.9 pin inside common/deps.ts — Deno-style npm: imports in .ts files aren't covered by Renovate's npm manager. Result: deno install resolves 5.8.0 per package.json, then the Deno script crashes because it imports a non-existent @5.0.9. This is breaking production CI for every consumer of @v4. Updates the Deno import to 5.8.0 and regenerates deno.lock (55 unit tests still pass). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #100 bumped `fast-xml-parser` to 5.8.0 in `ci-cd/package.json` (security fix), but Renovate cannot see the explicit `@5.0.9` pin inside `ci-cd/common/deps.ts` — Deno-style `npm:` imports in `.ts` files aren't covered by Renovate's npm manager.
Result on every consumer of `@v4`:
```
error: Could not find a matching package for 'npm:fast-xml-parser@5.0.9' in the node_modules directory.
at file:///.../ci-cd/common/deps.ts:16:39
##[error]Process completed with exit code 1.
```
Example failing run: dsb-norge/milo#237 (run 26276890209).
Fix
Verification
After merge
Cut `v4.11` and force-move `v4` to unblock all consumer repos.
Follow-up (separate)
Org-wide `dsb-norge/.github:renovate-config` should add a `customManagers` regex rule for `npm:@` in `.ts` files so this class of mismatch can't repeat.
🤖 Generated with Claude Code