From f9b8baa346dbbdfaf5d6994be6b01659c7dbe7df Mon Sep 17 00:00:00 2001 From: Arzumy MD & Mike Mazur Date: Thu, 5 May 2011 17:41:26 +0800 Subject: [PATCH 1/2] Add .rvmrc to .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9f30a35..2d74f5a 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ pkg/* *.gem .bundle +.rvmrc From a833ea607b2d2aeb37c1ad7f56695776c998fb98 Mon Sep 17 00:00:00 2001 From: Arzumy MD & Mike Mazur Date: Thu, 5 May 2011 18:14:48 +0800 Subject: [PATCH 2/2] Guard against @subqueries being empty For queries without subqueries (ie: UPDATE), calling SqlQuery#table raises a NoMethodError, since @subqueries is an empty array and [].first returns nil. This happens if such a query triggers a warning (see SqlQuery#warn). --- lib/query_reviewer/sql_query.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/query_reviewer/sql_query.rb b/lib/query_reviewer/sql_query.rb index 212ae6b..8979932 100644 --- a/lib/query_reviewer/sql_query.rb +++ b/lib/query_reviewer/sql_query.rb @@ -65,7 +65,7 @@ def max_severity end def table - @subqueries.first.table + @subqueries.first.try(:table) end def analyze!