Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Hi! I fixed some code for you! #6

Open
wants to merge 1 commit into from

5 participants

@node-migrator-bot

Hi!

I am migrationBot!

Did you know that path.{exists,existsSync} was moved to fs.{exists,existsSync}, and that tty.setRawMode(mode) was moved to tty.ReadStream#setRawMode() (i.e. process.stdin.setRawMode()) in node v0.8.0? Read more @API changes between v0.6 and v0.8

I automatically made some changes I think will help you migrate your codebase to node v0.8.0, please review these changes and merge them if you feel they are useful, If they are not you can ignore this Pull Request.

Have a Nice Day!

--migrationBot

@dsc
Owner

Won't this break compat with node < 0.8?

@dsc
Owner

That is, shouldn't it be: exists = fs.existsSync || path.existsSync ?

@rektide

I'm not sure how to attach a commit to this issue directly. My fix is part of this pull request, and it indeed does as you consider @dsc, it uses (fs.exists || path.exists) to avoid breaking older node versions:
#9 is a pull incorporating the specific commit rektide@57ca095

@ashtuchkin

we need this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 7, 2012
  1. @jfhbrook
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  compiler.js
View
2  compiler.js
@@ -842,7 +842,7 @@
}
cb || (cb = function(){});
p = expand(p);
- return path.exists(p, function(exists){
+ return fs.exists(p, function(exists){
var ps, _p;
if (exists) {
return cb(null);
Something went wrong with that request. Please try again.