Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

get session nock #178

Merged
merged 1 commit into from Feb 12, 2014

Conversation

Projects
None yet
2 participants
Collaborator

jo commented Jan 29, 2014

add nock for GET _session, needed for the testsuite to pass.

btw this is based on top of #176

@jo jo referenced this pull request Jan 29, 2014

Closed

Add nock for GET _session #177

Collaborator

jo commented Jan 29, 2014

Travis failed with the design_compact:test, which seems to be a bit flackery. I have restarted the build.

Collaborator

jo commented Jan 29, 2014

rebased

Owner

dscape commented Feb 12, 2014

Can I merge? Seems good to me. Also, this is just a test change correct? No need to publish to npm?

Collaborator

jo commented Feb 12, 2014

Yes, you can merge, this only affects the nock test.

But #176 needs to be in npm, therefore I would love to see a 4.1.2 release.

dscape added a commit that referenced this pull request Feb 12, 2014

@dscape dscape merged commit 63df48f into master Feb 12, 2014

1 check passed

default The Travis CI build passed
Details

@dscape dscape deleted the 177-get-session-nock branch Feb 12, 2014

Owner

dscape commented Feb 12, 2014

Published as v4.5.1

Collaborator

jo commented Feb 12, 2014

Awesome, thank you!

Owner

dscape commented Feb 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment