Added an example update handler to the readme. #181

Merged
merged 3 commits into from Feb 13, 2014

Conversation

Projects
None yet
2 participants
Contributor

alesch commented Feb 9, 2014

I've just spent two hours because of this, :-(
The references I've found online get its data from req.query.
Thanks!

http://jackhq.tumblr.com/post/16035106690/nano-v1-2-x-document-update-handler-support-v1-2-x
http://wiki.apache.org/couchdb/Document_Update_Handlers#Usage

Contributor

alesch commented Feb 9, 2014

I've just found this, which makes JSON.parse unnecesary:

"The server also parses the POST body into a JSON tree called form and does the same with the query string, in query."

http://couchapp.org/page/update-functions

alesch closed this Feb 9, 2014

alesch reopened this Feb 9, 2014

Contributor

alesch commented Feb 9, 2014

How can the Travis build fail for the first commit and succed for the second ?!?

Owner

dscape commented Feb 9, 2014

ahah @alesch welcome to the nano family.

I love it how you were just coming back here everytime you had an improvement.

Thank you, that is the spirit of open source.

If I can ask a last thing of you, can you add yourself to the contributors in package.json?

I will merge :)

Owner

dscape commented Feb 12, 2014

How is this going? Ready to merge?

Contributor

alesch commented Feb 13, 2014

Yes, please go ahead.
I've just added myself to the contribuitors list.

@dscape dscape added a commit that referenced this pull request Feb 13, 2014

@dscape dscape Merge pull request #181 from alesch/master
Added an example update handler to the readme.
0622747

@dscape dscape merged commit 0622747 into dscape:master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details
Owner

dscape commented Feb 13, 2014

Done :)

Owner

dscape commented Feb 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment