Skip to content

Cookies #77

Closed
wants to merge 1 commit into from

2 participants

@userIsNaN

Resubmitting pull request after problems with original


Adds cookie authentication functionality detailed in issue #71, plus
fixes issue with cookie jar in issue #73

Jonathan Mahoney Cookie authentication
Adds cookie authentication functionality detailed in issue #71, plus
fixes issue with cookie jar in issue #73
2f88c16
@userIsNaN

Sorry about that, not sure what happened with my original branches - this should be clean.

@dscape
Owner
dscape commented May 22, 2012

Thank you :)

@dscape
Owner
dscape commented May 22, 2012

Any ideas on how to run this without being an admin?

If not possible, can we create the admin for the test and then go back to admin party mode after the test is run?

This is the only blocker right now to get this merged, but idk how to do this.

Following up in #couchdb @freenode

@dscape
Owner
dscape commented May 22, 2012

Got some feedback, trying this now.

Thanks @rnewson

@dscape dscape added a commit that closed this pull request May 23, 2012
@dscape [cookies] fixes #77 #73 and #71 003127d
@dscape dscape closed this in 003127d May 23, 2012
@dscape
Owner
dscape commented May 23, 2012

Will be published as nano@3.0.4 as soon as tests pass in travis

@dscape
Owner
dscape commented May 23, 2012

@beardtwizzle hope you are happy with this :) It took some work (it wasn't acceptable to force people to have an admin user as our tests assume admin party mode with npm run nock_off) but its now done.

Can you please add documentation to the readme and write a blog post about the functionality?

I want to tweet this to a wider distribution of nano followers so they know about this possibility!

@userIsNaN
@dscape
Owner
dscape commented May 23, 2012
getting the set-up just right.

That's the core of nano, do little but right :)

@userIsNaN

Sorry for the delay - blog post now available at http://mahoney.eu/2012/05/23/couchdb-cookie-authentication-nodejs-nano/

@dscape
Owner
dscape commented May 23, 2012

Awesome :)

@dscape dscape added a commit that referenced this pull request Jun 20, 2012
@dscape [docs minor] shows the new auth apis
* relates to #81, #77 and #73
* cc @beardtwizzle
9e15871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.