Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cookies #77

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

rapidrapids commented May 22, 2012

Resubmitting pull request after problems with original


Adds cookie authentication functionality detailed in issue #71, plus
fixes issue with cookie jar in issue #73

Cookie authentication
Adds cookie authentication functionality detailed in issue #71, plus
fixes issue with cookie jar in issue #73
Contributor

rapidrapids commented May 22, 2012

Sorry about that, not sure what happened with my original branches - this should be clean.

Owner

dscape commented May 22, 2012

Thank you :)

Owner

dscape commented May 22, 2012

Any ideas on how to run this without being an admin?

If not possible, can we create the admin for the test and then go back to admin party mode after the test is run?

This is the only blocker right now to get this merged, but idk how to do this.

Following up in #couchdb @freenode

Owner

dscape commented May 22, 2012

Got some feedback, trying this now.

Thanks @rnewson

@dscape dscape closed this in 003127d May 23, 2012

Owner

dscape commented May 23, 2012

Will be published as nano@3.0.4 as soon as tests pass in travis

Owner

dscape commented May 23, 2012

@beardtwizzle hope you are happy with this :) It took some work (it wasn't acceptable to force people to have an admin user as our tests assume admin party mode with npm run nock_off) but its now done.

Can you please add documentation to the readme and write a blog post about the functionality?

I want to tweet this to a wider distribution of nano followers so they know about this possibility!

Contributor

rapidrapids commented May 23, 2012

Give me till this evening and all shall be done! :)

Thanks for this, and all the hard work getting the set-up just right.

Owner

dscape commented May 23, 2012

getting the set-up just right.

That's the core of nano, do little but right :)

Contributor

rapidrapids commented May 23, 2012

Sorry for the delay - blog post now available at http://mahoney.eu/2012/05/23/couchdb-cookie-authentication-nodejs-nano/

Owner

dscape commented May 23, 2012

Awesome :)

dscape added a commit that referenced this pull request Jun 20, 2012

[docs minor] shows the new auth apis
* relates to #81, #77 and #73
* cc @beardtwizzle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment