Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest making class-based resources re-use module DscResource.Base #404

Closed
johlju opened this issue Jan 3, 2023 · 0 comments · Fixed by #405
Closed

Suggest making class-based resources re-use module DscResource.Base #404

johlju opened this issue Jan 3, 2023 · 0 comments · Fixed by #405
Labels
in progress The issue is being actively worked on by someone.

Comments

@johlju
Copy link
Member

johlju commented Jan 3, 2023

The class ResourceBase and Reason, plus enum Ensure have been moved to the module DscResource.Base so that we don't need to duplicate code between DSC resource modules.

Suggest that the class-based resources in thi module re-use that module by modifying RequiredModules.ps1 and build.yaml to use it the same way we re-use commands from module DscResource.Common.

This move has already been done for SqlServerDsc, and I have tested so that the resources from different modules do not clash when re-using the module DscResource.Base. I documented it here: dsccommunity/SqlServerDsc#1790
@johlju johlju mentioned this issue Jan 3, 2023
Merged
9 tasks
@johlju johlju added the in progress The issue is being actively worked on by someone. label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
1 participant
@johlju