Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: xDnsServerSetting: Resource can be used more than once in the same configuration #156

Closed
johlju opened this issue Feb 10, 2021 · 1 comment · Fixed by #161
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Feb 10, 2021

Details of the scenario you tried and the problem that is occurring

This resource could be used several times by changing the Name to any random text. This will lead to ping-pong behavior.

Verbose logs showing the problem

Suggested solution to the issue

This resource should be change to the single-instance DSC resource pattern

The DSC configuration that is used to reproduce the issue (as detailed as possible)

configuration MSFT_xDnsServerDiagnostics_SetDiagnostics_Config
{
    Import-DscResource -ModuleName 'xDnsServer'

    node $AllNodes.NodeName
    {
        xDnsServerDiagnostics 'Set1'
        {
            Name               = 'MyKeyName1'
            AddressAnswerLimit = 0
        }

        xDnsServerDiagnostics 'Set2'
        {
            Name               = 'MyKeyName1'
            AddressAnswerLimit = 1
        }
    }
}

The operating system the target node is running

Any.

Version and build of PowerShell the target node is running

N/A

Version of the DSC module that was used

The version in main branch.

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Feb 10, 2021
@johlju johlju changed the title xDnsServerSetting: Resource can be used more than once in the same configuration BREAKING CHANGE: xDnsServerSetting: Resource can be used more than once in the same configuration Feb 10, 2021
@johlju
Copy link
Member Author

johlju commented Feb 14, 2021

I think this resource should use parameter DnsServer like the other resources so it possible to specify a DNS server name to configure.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Feb 14, 2021
johlju added a commit that referenced this issue Feb 16, 2021
- xDnsServerSetting
  - BREAKING CHANGE: The mandatory parameter was replaced by the mandatory
    parameter `DnsServer`. This prevents the resource from being used twice in the
    same configuration using the same value for the parameter `DnsServer` (issue #156).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. bug The issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant