Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDnsServer: Replace ConvertTo-CimInstance with the one in DscResource.Common #167

Closed
johlju opened this issue Feb 15, 2021 · 0 comments · Fixed by #169
Closed

xDnsServer: Replace ConvertTo-CimInstance with the one in DscResource.Common #167

johlju opened this issue Feb 15, 2021 · 0 comments · Fixed by #169
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Feb 15, 2021

In the module DnsServerDsc.Common there is a helper function ConvertTo-CimInstance. That helper function is available through the common module DscResource.Common. The one in DnsServerDsc.Common should be removed in favor of the one in DscResource.Common.

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Feb 15, 2021
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Feb 15, 2021
johlju added a commit that referenced this issue Feb 20, 2021
- xDnsServer
  - Remove helper function `Remove-CommonParameter` in favor of the one in
    module _DscResource.Common_ (issue #166).
  - Remove helper function `ConvertTo-CimInstance` in favor of the one in
    module _DscResource.Common_ (issue #167).
  - Remove helper function `ConvertTo-HashTable` in favor of the one in
    module _DscResource.Common_ (issue #168).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant