Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: xDnsServerSetting: Remove properties LogIPFilterList, LogFilePath, LogFileMaxSize, and EventLogLevel #190

Closed
johlju opened this issue Feb 27, 2021 · 2 comments · Fixed by #202
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Feb 27, 2021

Details of the scenario you tried and the problem that is occurring

Suggest removing the property LogIPFilterList in favor of the already present property FilterIPAddressList in the resource xDnsServerDiagnostics to avoid ping-pong behavior. This will also simplify the resource xDnsServerSetting.

Verbose logs showing the problem

Not available.

Suggested solution to the issue

Remove the property LogIPFilterList and use the resource xDnsServerDiagnostics to enforce this setting instead.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

Configuration xDnsServerSetting_CurrentNode_Config
{
    Import-DscResource -ModuleName 'xDnsServer'

    Node localhost
    {
        xDnsServerSetting 'SetIpFilterList'
        {
            DnsServer       = 'localhost'
            LogIPFilterList = @('168.63.129.16', '168.63.129.18')
        }

        xDnsServerDiagnostics 'Diagnostics'
        {
            DnsServer           = 'localhost'
            FilterIPAddressList = @('10.0.10.1', '10.0.10.2')
        }
    }
}

The operating system the target node is running

Any Windows

Version and build of PowerShell the target node is running

Windows PowerShell 5.1

Version of the DSC module that was used

2.0.0

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Feb 27, 2021
@johlju johlju changed the title BREAKING CHANGE: xDnsServerSetting: Remove property LogIPFilterList BREAKING CHANGE: xDnsServerSetting: Remove properties LogIPFilterList, LogFilePath, and LogFileMaxSize Feb 28, 2021
@johlju
Copy link
Member Author

johlju commented Feb 28, 2021

We should also remove the properties LogFilePath and LogFileMaxSize too. They can be enforced by the resource xDnsServerDiagnostics with the properties LogFilePath and MaxMBFileSize.

@johlju johlju changed the title BREAKING CHANGE: xDnsServerSetting: Remove properties LogIPFilterList, LogFilePath, and LogFileMaxSize BREAKING CHANGE: xDnsServerSetting: Remove properties LogIPFilterList, LogFilePath, LogFileMaxSize, and EventLogLevel Feb 28, 2021
@johlju
Copy link
Member Author

johlju commented Feb 28, 2021

Also remove the properties EventLogLevel. It can be enforced by the resource xDnsServerDiagnostics with the properties EventLogLevel.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 2, 2021
johlju added a commit that referenced this issue Mar 17, 2021
- xDnServerSetting
  - BREAKING CHANGE: The properties `LogIPFilterList`, `LogFilePath`, `LogFileMaxSize`,
    and `EventLogLevel` have been removed. Use the resource _xDnsServerDiagnostics_
    with the properties `FilterIPAddressList`, `LogFilePath`, `MaxMBFileSize`,
    and `EventLogLevel` respectively to enforce these settings (issue #190).
    This is done in preparation to support more settings through the cmdlet
    `Get-DnsServerSetting` for the resource _xDnServerSetting_, and these
    values are not available through that cmdlet.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant