Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xDnsRecord: Deprecate resource #220

Closed
johlju opened this issue Mar 23, 2021 · 2 comments · Fixed by #222
Closed

xDnsRecord: Deprecate resource #220

johlju opened this issue Mar 23, 2021 · 2 comments · Fixed by #222
Labels
enhancement The issue is an enhancement request. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.

Comments

@johlju
Copy link
Member

johlju commented Mar 23, 2021 •
edited
Loading

There are now separate resources that covers the functionality for the resource xDnsRecord (see https://github.com/dsccommunity/xDnsServer/projects/1). So suggest we deprecate the resource, and then later remove the resource when we rename the module to DnsServerDsc.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'. breaking change When used on an issue, the issue has been determined to be a breaking change. labels Mar 23, 2021
@johlju johlju changed the title xDnsRecord: Deprecate and remove resource xDnsRecord: Deprecate resource Mar 23, 2021
@johlju johlju mentioned this issue Mar 23, 2021
Closed
@johlju johlju removed the breaking change When used on an issue, the issue has been determined to be a breaking change. label Mar 23, 2021
@Sudman1
Copy link
Contributor

Sudman1 commented Mar 23, 2021

Along with deprecation, should we close issues #67 (PR #108), #98, #129, and #171 - which are concerned with the xDnsRecord resource - as moot?

@johlju
Copy link
Member Author

johlju commented Mar 23, 2021

Yes, that was my plan. Close anything related to xDnsRecord. It will be removed as soon as we released 2.0.0.0, as DnsServerDsc will be released as 3.0.0.0 shortly after.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 24, 2021
@johlju johlju mentioned this issue Mar 24, 2021
Merged
9 tasks
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xDnsServer: Add deprecation messages to CHANGELOG.md johlju/DnsServerDsc
2 participants
@johlju @Sudman1