Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practice is to add resources to module manifest #3

johlju opened this issue Sep 18, 2019 · 1 comment · Fixed by #4

Best practice is to add resources to module manifest #3

johlju opened this issue Sep 18, 2019 · 1 comment · Fixed by #4
enhancement good first issue


Copy link

@johlju johlju commented Sep 18, 2019

During deployment of v1.0.0 there was a warning outputted that there is a best practice to include the resources in the module manifest. I suggest we do that.

VERBOSE: Performing the operation "Publish-Module" on target "Version '1.0.0' of module 'GPRegistryPolicyDsc'".
This module 'C:\Users\appveyor\AppData\Local\Temp\1\805144811\GPRegistryPolicyDsc\GPRegistryPolicyDsc.psd1' has exported DscResources. As a best practice, include exported DSC resources in the module manifest file(.psd1). If your PowerShell version is higher than 5.0, run Update-ModuleManifest -DscResourcesToExport to update the manifest with ExportedDscResources field.
VERBOSE: Successfully published module 'GPRegistryPolicyDsc' to the module publish location ''. Please allow few minutes for 'GPRegistryPolicyDsc' to show up in the search results.
Name                Version ModuleType ModuleBase                     
----                ------- ---------- ----------                     
GPRegistryPolicyDsc 1.0.0     Manifest C:\projects\gpregistrypolicydsc
Build success
@johlju johlju added enhancement good first issue help wanted labels Sep 18, 2019
@jcwalker jcwalker self-assigned this Sep 19, 2019
@jcwalker jcwalker added the in progress label Sep 19, 2019
johlju pushed a commit that referenced this issue Sep 26, 2019
- Fixed issue #3
- Updated release logic to not include .git folder.
@johlju johlju removed help wanted in progress labels Sep 26, 2019
Copy link
Member Author

@johlju johlju commented Sep 26, 2019

Resolve in PR #4

@johlju johlju closed this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
enhancement good first issue
None yet

Successfully merging a pull request may close this issue.

2 participants