Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-TargetResource always failes non-English OS #11

Closed
Amedama96 opened this issue Dec 18, 2016 · 1 comment
Closed

Test-TargetResource always failes non-English OS #11

Amedama96 opened this issue Dec 18, 2016 · 1 comment
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@Amedama96
Copy link
Contributor

If you are using non english version of the Windows, Test-TargetResource always failes.

This issue caused by the code

$DismGetFeatures = & dism.exe /Online /Get-Features

For fix this issue, Please add '/English' option.

$DismGetFeatures = & dism.exe /Online /Get-Features /English
Amedama96 added a commit to Amedama96/xDismFeature that referenced this issue Dec 26, 2016
@Amedama96
Add '/English' option to dism.exe
7204512 
Fix issue dsccommunity#11
@kwirkykat kwirkykat added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jan 25, 2017
Amedama96 added a commit to Amedama96/xDismFeature that referenced this issue Jan 28, 2017
@Amedama96
Add '/English' option to dism.exe
5576de2 
Fix issue dsccommunity#11
@Amedama96 Amedama96 mentioned this issue Jan 28, 2017
Merged
@mkht
Copy link

mkht commented Jun 17, 2017

I met this issue too.
won't fix ?

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 17, 2018
Amedama96 added a commit to Amedama96/xDismFeature that referenced this issue May 17, 2018
@Amedama96
Add '/English' option to dism.exe
e9557bd 
Fix issue dsccommunity#11
Amedama96 added a commit to Amedama96/xDismFeature that referenced this issue May 17, 2018
@Amedama96
Add change log in the README
8090d05 
related dsccommunity#11
johlju pushed a commit that referenced this issue May 21, 2018
@Amedama96 @johlju
Add '/English' option to dism.exe (#14)
022d079 
* Added unit test
* Fixed issue that Test-TargetResource always fails on non-English OS (issue #11)
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kwirkykat @johlju @Amedama96 @mkht