Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Pull of DSCResource.Tests is Called 36 Times During a Full Test Job #590

Closed
mhendric opened this issue Mar 7, 2019 · 0 comments · Fixed by #591
Closed

Git Pull of DSCResource.Tests is Called 36 Times During a Full Test Job #590

mhendric opened this issue Mar 7, 2019 · 0 comments · Fixed by #591
Assignees
Labels
bug The issue is a bug. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.

Comments

@mhendric
Copy link
Contributor

mhendric commented Mar 7, 2019

Details of the scenario you tried and the problem that is occurring

A refresh of the DSCResource.Tests module is currently performed 36 times if you execute all Unit and Integration tests. This makes it far more likely to encounter #505 . This should be fixed to only update DSCResource.Tests a maximum of one time per job.

Verbose logs showing the problem

All scripts calling this function:

Tests\Integration\MSFT_xArchive.EndToEnd.Tests.ps1:16:        $script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xArchive.Integration.Tests.ps1:20:        $script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xEnvironmentResource.EndToEnd.Tests.ps1:19:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xEnvironmentResource.Integration.Tests.ps1:16:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xGroupResource.Integration.Tests.ps1:17:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xMsiPackage.EndToEnd.Tests.ps1:22:        $script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xMsiPackage.Integration.Tests.ps1:13:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xPackageResource.Integration.Tests.ps1:8:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xRegistryResource.EndToEnd.Tests.ps1:21:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xRegistryResource.Integration.Tests.ps1:21:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xScriptResource.Integration.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xServiceResource.Integration.Tests.ps1:23:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xUserResource.Integration.Tests.ps1:19:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xWindowsFeature.Integration.Tests.ps1:20:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xWindowsOptionalFeature.Integration.Tests.ps1:8:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xWindowsPackageCab.Integration.Tests.ps1:8:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\MSFT_xWindowsProcess.Integration.Tests.ps1:21:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\xFileUpload.Integration.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\xGroupSet.Integration.Tests.ps1:17:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\xProcessSet.Integration.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\xServiceSet.Integration.Tests.ps1:23:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\xWindowsFeatureSet.Integration.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Integration\xWindowsOptionalFeatureSet.Integration.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xArchive.Tests.ps1:20:        $script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xEnvironmentResource.Tests.ps1:18:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xGroupResource.Tests.ps1:17:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xMsiPackage.Tests.ps1:20:        $script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xPackageResource.Tests.ps1:10:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xRegistryResource.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xScriptResource.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xServiceResource.Tests.ps1:18:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xUserResource.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xWindowsFeature.Tests.ps1:14:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xWindowsOptionalFeature.Tests.ps1:8:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xWindowsPackageCab.Tests.ps1:8:$script:testEnvironment = Enter-DscResourceTestEnvironment `
Tests\Unit\MSFT_xWindowsProcess.Tests.ps1:15:$script:testEnvironment = Enter-DscResourceTestEnvironment `

Suggested solution to the issue

See #516

Version of the DSC module that was used ('dev' if using current dev branch)

dev

@mhendric mhendric added bug The issue is a bug. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'. labels Mar 7, 2019
@SteveL-MSFT SteveL-MSFT added this to High Priority in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from High Priority in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.
Projects
None yet
2 participants