Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWebAdministration: Optimized exporting in the module manifest for best performance #523

Merged
merged 3 commits into from Oct 6, 2019

Conversation

@zufishanali
Copy link
Contributor

zufishanali commented Oct 6, 2019

Pull Request (PR) description

Optimized exporting in the module manifest to match best practices and updated the CHANGELOG.md accordingly.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 6, 2019

CLA assistant check
All CLA requirements met.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #523 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #523   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          17       17           
  Lines        2661     2661           
=======================================
  Hits         2432     2432           
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b7113c...c615301. Read the comment docs.

@johlju johlju added the needs review label Oct 6, 2019
johlju added 2 commits Oct 6, 2019
@johlju
johlju approved these changes Oct 6, 2019
Copy link
Member

johlju left a comment

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 10338a1 into dsccommunity:dev Oct 6, 2019
5 checks passed
5 checks passed
code-review/reviewable 2 files reviewed
Details
codecov/patch Coverage not affected when comparing 6b7113c...c615301
Details
codecov/project 91.39% remains the same compared to 6b7113c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
@johlju

This comment has been minimized.

Copy link
Member

johlju commented Oct 6, 2019

@zufishanali Thank you for this! 😄

@johlju johlju removed the needs review label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.