Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Board Member card with swiperjs #71

Merged
merged 4 commits into from Oct 18, 2022
Merged

Conversation

jaydeepdey03
Copy link
Contributor

@jaydeepdey03 jaydeepdey03 commented Oct 17, 2022

πŸ› οΈ Fixes Issue

Added swipable cards featuring Board members of GDSC

πŸ‘¨β€πŸ’» Changes proposed

  • Added SwiperJS
  • Made it responsive
  • Added ./data/Boardmember.json for dynamic updation of card content

πŸ”§ Check List (Check the type of issue it fixes)

  • Bug Fix
  • New Extension
  • Enhancement
  • Documentation

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have done git pull before adding my new changes
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

image

@vercel
Copy link

vercel bot commented Oct 17, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
dscvitchennai βœ… Ready (Inspect) Visit Preview Oct 18, 2022 at 4:48AM (UTC)

window.addEventListener("resize", handleResize);
return () => window.removeEventListener("resize", handleResize);
}
}, [hasWindow]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar

React Hook useEffect has a missing dependency: 'getWindowDimensions'. Either include it or remove the dependency array.
components/Boardmembercard.jsx Fixed Show resolved Hide resolved
Comment on lines +59 to +63
<img
src={`/Icons/down-arrow.png`}
className="w-10 h-10 cursor-pointer"
alt=""
/>

Check warning

Code scanning / ESLint

Prevent usage of `<img>` element to prevent layout shift.

Do not use `<img>` element. Use `<Image />` from `next/image` instead. See: https://nextjs.org/docs/messages/no-img-element
@Arjun31415
Copy link
Contributor

Please check the code warnings and please don't use image. To prevent layout shift please use https://nextjs.org/docs/api-reference/next/future/image if styling on next/Image is not possible

"color": "#4b916c"
},
{
"name": "Nimish Kashyap",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He is not the blockchain lead please chain the data, or add other people whom you know

style={{ marginTop: "3rem" }}
>
<Link href={`/`}>
<img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use next/future/image if you want to achieve the same results as using img tag with classname

components/Boardmembercard.jsx Fixed Show resolved Hide resolved
@jaydeepdey03
Copy link
Contributor Author

jaydeepdey03 commented Oct 17, 2022

@Arjun31415 @FidalMathew

I have added <Image /> from next/future/image to ./components/Boardmembers.jsx

for Footer.jsx, the <Image /> tag is making background image blurred

components/Events.jsx Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants