Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

fixed minor regression causing duplicate ids for slide indicators, ad…

…ded related test
  • Loading branch information...
commit f9a8eaabe7dba9c8f98bbae65216de94551d67eb 1 parent 7c46713
@jeremybanks jeremybanks authored
Showing with 17 additions and 0 deletions.
  1. +1 −0  js/setup.js
  2. +16 −0 test/index.html
View
1  js/setup.js
@@ -743,6 +743,7 @@ addEventListener( "DOMContentLoaded", function() {
}
teDiv.id = "popcorn-slideshow-div-" + count;
}
+ count++;
teDiv.innerHTML = "<p><b></b></p>";
teDiv.className = "popcorn-slideshow";
View
16 test/index.html
@@ -190,6 +190,22 @@
frame.jQuery(frame.document).trigger(e);
}
} );
+
+ atest( "Slide indicators exist", function( toCleanUp ) {
+ var frame = getFramedWindow( "../index.html", toCleanUp );
+
+ return function poll() {
+ return ( frame._slideDriveReady ) ? onReady : poll;
+ }
+
+ function onReady() {
+ atest("div-1 exists and has nonzero width",
+ parseFloat(frame.document.getElementById("popcorn-slideshow-div-1").style.width) > 0);
+ atest("div-14 exists and has nonzero width",
+ parseFloat(frame.document.getElementById("popcorn-slideshow-div-14").style.width) > 0);
+
+ }
+ });
} );
atest( "./template.html", 120, function( toCleanUp ) {
Please sign in to comment.
Something went wrong with that request. Please try again.