Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printable view should have clickable slides #9

Closed
dseif opened this issue Apr 11, 2012 · 2 comments
Closed

Printable view should have clickable slides #9

dseif opened this issue Apr 11, 2012 · 2 comments

Comments

@dseif
Copy link
Owner

dseif commented Apr 11, 2012

Inside the printable view ( hit the "t" key on your keyboard ) we get a list of all of the slide and their corresponding transcript side-by-each, which is nice but could be better. Being able to click on the slide/transcript element should take you to that particular slide.

Like Greg mentioned, it may be best to acutally create a small button in the top/bottom(?) corner of each slide saying something along the lines of "Go to Slide" or something.
banksJeremy pushed a commit to jeremyBanks/slide-drive that referenced this issue Apr 16, 2012
@jeremyBanks
Add a "Go to Slide" link to the corner slide as suggested in dseif/ds…
eb0497a 
…eif#9.
banksJeremy pushed a commit to jeremyBanks/slide-drive that referenced this issue Apr 16, 2012
@jeremyBanks
Keep the useful href but handle the click in JS.
9303708 
for dseif#9
@banksJeremy banksJeremy mentioned this issue Apr 16, 2012
Merged
@dseif
Copy link
Owner Author

dseif commented Apr 16, 2012

This is looking great! Added a few comments in the pull request. Once you update I will review again, thanks Jeremy!

@dseif
Copy link
Owner Author

dseif commented Apr 25, 2012

Pull request was closed, closing the issue.

@dseif dseif closed this as completed Apr 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dseif