New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpreadsheetBuilder: build methods with template parameter disappeared #2

Closed
asaremba opened this Issue Nov 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@asaremba

asaremba commented Nov 2, 2017

In the old Groovy Spreadsheet Builder project, the SpreadsheetBuilder interface had not one but three build methods, two of them containing a template parameter. The documentation still mentions this ("You can pass an existing spreadsheet file as a template as the very first argument of the build method."), but in fact these methods have disappeared since version 1.0.
My proposal is not to adapt the documentation but to revive the methods in the code; I found it useful to be able to provide an Excel template file.

@asaremba

This comment has been minimized.

asaremba commented Nov 2, 2017

After looking into the source code, I noticed that the template parameter is now available in the create method. As a consequence, I now propose to just update the documentation.
Additional suggestion: A subproject with a few (executable) examples would be helpful for the beginner (and more easily accessible than those that can be found in the Spock tests).

@musketyr musketyr closed this in b55d13e Nov 5, 2017

musketyr added a commit that referenced this issue Nov 24, 2017

Merge pull request #4 from dsl-builders/fix/2-automatic-width-with-fi…
…lter

Fixed #2 automatic width with filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment