-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check whether gas readings are optional #34
Comments
Original comment by Dennis Siemensma (Bitbucket: dennissiemensma, GitHub: dennissiemensma):
|
This issue is required for @danielterhorst as he does not have a meter which supports gas readings. |
@danielterhorst heb je toevallig een snapshot van je DSMR telegram? Of mis je gewoon deze velden onderaan?
|
Altered database to allow nullable extra devices. Tests work fine now, after defaulting some values to None:
Next up are all the services expecting to have at least gas consumption tracked. |
Refactored the tests a bit. Created separate fixtures without gas data, sub classed the tests and altered the fixtures, having them execute the same tests, with different data. Any code depending on gas readings came forward. Although it's all just based on asumptions without a production example. |
Added some checks to interface. Will continue later. Merged to default for now. |
Flushing the database for checking whether the views run without data does not work for postgresql and mysql. I'll have to refactor that later, by just calling the model's |
Fixed tests, as they failed for mysql & postgres when calling |
As the gas is now optional, technically, I think I'll close this one and have #70 as followup. Which points to the actual interface and capabilities regarding gas & electricity returned. |
Merged & deployed. |
Because sometimes there is simply no gas meter attached to the dsmr device.
Possibly affects:
The text was updated successfully, but these errors were encountered: