Add env setting to fleet config for on-prem fleets #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
reviewed
Aug 6, 2024
| pass | ||
|
|
||
|
|
||
| class ApplyEnvVarsConfiguratorMixin(BaseApplyConfigurator): |
Collaborator
There was a problem hiding this comment.
Any reason to inherit Mixin from BaseApplyConfigurator? I'd expect Mixin to not inherit from the base class.
Collaborator
Author
There was a problem hiding this comment.
For type annotations only, no reason from the runtime point of view. I have no strong opinion on this, though.
Collaborator
There was a problem hiding this comment.
I see. I'd not depend on super to register mixin args but provide a method like register_env_args() similar to apply_env_vars() and call it from the child explicitly. It's easier to reason about and doesn't require to inherit the mixin.
Collaborator
Author
There was a problem hiding this comment.
Agree, I'll update the PR.
r4victor
reviewed
Aug 6, 2024
| _CM = TypeVar("_CM", bound=CoreModel) | ||
|
|
||
|
|
||
| def is_core_model_instance(instance: Any, class_: Type[_CM]) -> TypeGuard[_CM]: |
Collaborator
There was a problem hiding this comment.
Didn't know about TypeGuard. That's cool, thanks!
r4victor
approved these changes
Aug 6, 2024
use explicit helper classmethod register_env_args() instead
un-def
force-pushed
the
1466_add_fleet_conf_env_vars_support_for_on_prem
branch
from
94a1d77 to
4d2a82b
Compare
jvstme
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1466