[Internal]: Ensure all files end with a newline #2227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a pre-commit hook to ensure that all text files end with a newline. Since some editors add a newline automatically, enforcing all files have one will help avoid unnecessary edits as well as warnings in PR diffs. Python files are already forced to have a newline by ruff, so this change only affects non-Python files (Markdown, YAML, etc).
un-def
approved these changes
Jan 27, 2025
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Feb 9, 2025
This commit adds a pre-commit hook to ensure that all text files end with a newline. Since some editors add a newline automatically, enforcing all files have one will help avoid unnecessary edits as well as warnings in PR diffs. Python files are already forced to have a newline by ruff, so this change only affects non-Python files (Markdown, YAML, etc).
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 4, 2025
This commit adds a pre-commit hook to ensure that all text files end with a newline. Since some editors add a newline automatically, enforcing all files have one will help avoid unnecessary edits as well as warnings in PR diffs. Python files are already forced to have a newline by ruff, so this change only affects non-Python files (Markdown, YAML, etc).
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 5, 2025
This commit adds a pre-commit hook to ensure that all text files end with a newline. Since some editors add a newline automatically, enforcing all files have one will help avoid unnecessary edits as well as warnings in PR diffs. Python files are already forced to have a newline by ruff, so this change only affects non-Python files (Markdown, YAML, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a pre-commit hook to ensure that all text files end with a newline. Since some editors add a newline automatically, enforcing all files have one will help avoid unnecessary edits as well as warnings in PR diffs.
Python files are already forced to have a newline by ruff, so this change only affects non-Python files (Markdown, YAML, etc).