Skip to content

Fix idle duration: off and forbid negative durations #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

Fix idle duration: off and forbid negative durations #3151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ee5c2b
Fix bool parsing for idle_duration
r4victor Oct 6, 2025
e33cb5c
Forbid negative durations
r4victor Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/dstack/_internal/core/models/profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,21 @@ def parse_stop_duration(
def parse_off_duration(v: Optional[Union[int, str, bool]]) -> Optional[Union[Literal["off"], int]]:
if v == "off" or v is False:
return "off"
if v is True:
if v is True or v is None:
return None
return parse_duration(v)
duration = parse_duration(v)
if duration < 0:
raise ValueError("Duration cannot be negative")
return duration


def parse_idle_duration(v: Optional[Union[int, str]]) -> Optional[int]:
if v == "off" or v == -1:
def parse_idle_duration(v: Optional[Union[int, str, bool]]) -> Optional[int]:
# Differs from `parse_off_duration` to accept negative durations as `off`
# for backward compatibility.
if v == "off" or v is False or v == -1:
return -1
if v is True:
return None
return parse_duration(v)


Expand Down