Support GCP reservations #3186
Merged
Support GCP reservations #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to specify a specifically-targeted GCP reservation in fleet configurations: ```yaml type: fleet nodes: 1 backends: [gcp] reservation: my-reservation ``` For reservations shared between projects, the full syntax can be used to reference the project that owns the reservation: ```yaml type: fleet nodes: 1 backends: [gcp] reservation: projects/my-proj/reservations/my-reservation ``` `dstack` will locate the specified reservation, suggest offers that match the reservation's properties, and provision instances in the reservation. If there are multiple reservations with the specified name, all of them will be considered for provisioning. Using reservations requires the `compute.reservations.list` permission in the project that owns the reservations. The implementation was only tested with on-demand reservations. Whether other reservation types work can be confirmed later, which includes Future Reservations in Calendar Mode and Future Reservations in AI Hypercomputer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify a specifically-targeted GCP
reservation in fleet configurations:
For reservations shared between projects, the full
syntax can be used to reference the project that
owns the reservation:
dstackwill locate the specified reservation,suggest offers that match the reservation's
properties, and provision instances in the
reservation. If there are multiple reservations
with the specified name, all of them will be
considered for provisioning.
Using reservations requires the
compute.reservations.listpermission in theproject that owns the reservations.
The implementation was only tested with on-demand
reservations. Whether other reservation types work
can be confirmed later, which includes Future
Reservations in Calendar Mode and Future
Reservations in AI Hypercomputer.
Closes #3162