-
Notifications
You must be signed in to change notification settings - Fork 204
Fix #921 #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheBits
merged 16 commits into
master
from
issue_921-fix-instance-statuses-when-using-the-vastai
Feb 22, 2024
Merged
Fix #921 #922
TheBits
merged 16 commits into
master
from
issue_921-fix-instance-statuses-when-using-the-vastai
Feb 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-for-pool-routers-and-process_pools
…ts-for-pool-routers-and-process_pools
…ts-for-pool-routers-and-process_pools
fb58d5a to
88ee621
Compare
Egor-S
reviewed
Feb 22, 2024
| backend_data: Optional[str] = Field(default=None) # backend-specific data in json | ||
|
|
||
|
|
||
| class InstanceRuntime(Enum): |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could someday replace dockerized with this enum
|
|
||
| job_provisioning_data = None | ||
| if job_model.job_provisioning_data is not None: | ||
| job_provisioning_data = parse_raw_as( |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, that for plain types it's simpler to use BaseModel.parse_raw
…nce-statuses-when-using-the-vastai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.