Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gitsigns #116

Closed
Shahabaz-Bagwan opened this issue Aug 16, 2023 · 4 comments
Closed

Add support for gitsigns #116

Shahabaz-Bagwan opened this issue Aug 16, 2023 · 4 comments

Comments

@Shahabaz-Bagwan
Copy link

First of all thank you for creating such a useful plugin.

Feature Request

After using it I feel like the scroll bar should show overview of the document like vscode have.

How I am getting that feature right now

To mitigate this I am using it with other plugin "nvim-scrollbar" irony is the scrollbar plugin shows view of the scroll and scrollview plugin actually implements scrolling 😆

My config:

https://github.com/Shahabaz-Bagwan/nvChadCustom/blob/922ab1f5382f2df8d3b3cb8e741f6d878bd65fea/plugins.lua#L153

@XXiaoA
Copy link

XXiaoA commented Aug 17, 2023

Gitsigns has been supported. Take a look at https://github.com/dstein64/nvim-scrollview/blob/main/lua/scrollview/contrib/gitsigns.lua

@dstein64
Copy link
Owner

@Shahabaz-Bagwan, in addition to the link that @XXiaoA posted, you might also find the following comment helpful:

#87 (comment)

Because gitsigns is not supported as a built-in sign group, it can't be enabled by adding it to scrollview_signs_on_startup. Rather, it has to be enabled with:

require('scrollview.contrib.gitsigns').setup()

@subev
Copy link

subev commented Dec 14, 2023

@dstein64 Add this to the main README, I almost would have missed adding it.
Great plugin, great work 🙇

@dstein64
Copy link
Owner

dstein64 commented Feb 11, 2024

Hi @subev, I'm glad to hear you like the plugin.

I just added a paragraph to the README that mentions the contrib sign groups (coc and gitsigns).

nvim-scrollview/README.md

Lines 103 to 107 in 8e26805

The [contrib](lua/scrollview/contrib) directory contains sign group
implementations that are not built-in (e.g., `coc`, `gitsigns`), but may be
useful to some users. The code there does not receive the same level of support
as the main source code, and may be less stable. Use at your own risk. For
installation instructions and other documentation, see the source code files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants