Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIAP metric output table with red and green visual #139

Merged
merged 3 commits into from
May 18, 2020
Merged

Conversation

lflaherty-dstl
Copy link
Contributor

Adds a new kind of metric visualisation, so far implemented for SIAP metrics only. This allows metrics to be displayed along with a short description of what the metric means as well as a target value for each metric (as these can vary). The metric value is also shown with a coloured background from red-green to visually represent the accuracy of each metric.

This will be of particular interest to the OSTEWG challenge participants, as it provides an easy way of comparing the accuracy of different trackers.

Copy link
Member

@sdhiscocks sdhiscocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, just needs inheritance addressing.

@@ -36,6 +36,27 @@ class MetricManager(Base):
"""


class MetricTableGenerator(Base):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should inherit from MetricGenerator, and then generate_table could renamed compute_metric method.

@sdhiscocks sdhiscocks merged commit 5fe6068 into master May 18, 2020
@sdhiscocks sdhiscocks deleted the metric_tables branch May 18, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants