More work on feature/record download info #1

Closed
wants to merge 34 commits into
from

Projects

None yet

6 participants

tgecho commented Apr 10, 2012

Hey! I pushed forward on your pull request as far as I could. I've tried to address the concerns raised in the original (hardcoded paths and other test issues). I also merged in upstream develop. Here's a compare of the actual changes I've made: tgecho/pip@488b29d...feature/record-download-info

I'm a little puzzled as to why the tests failed so spectacularly in python 3, but I started with replacing the iteritems() and the errors all seemed to go away. I still can't wrap my head around what is breaking with bundling, and there's another unrelated error in test_editable_git_upgrade (only in 2.5/2.6) that I don't get either.

Anyway, it's progress. If you don't have time to continue right now, I'll see what I can do. I figured I'd send the code to you first before stepping on your toes upstream. :)

http://travis-ci.org/#!/tgecho/pip/builds/1061109

dengzhp and others added some commits Feb 13, 2012
@dengzhp dengzhp use dummy_threading when the threading module is not present. ccad8da
@carljm carljm Merge pull request #455 from dengzhp/develop
use dummy_threading when the threading module is not present.
e063132
@jezdez jezdez Bumped version to 1.1 and updated changelog slightly. 40ac381
@jezdez jezdez Merge branch 'release/1.1' into develop 5b093e2
@jezdez jezdez Bumped to post1. 9c8ab2f
@carljm carljm Add reference to --environment along with -E in changelog; refs #460. 9002cfe
@jezdez jezdez Added experimental config file for Travis CI. aafc7aa
@jezdez jezdez Merge branch 'develop' of github.com:pypa/pip into develop 0080889
@jezdez jezdez One character change to trigger Travis build. 52ea21a
@jezdez jezdez Remove git-core from list of dependencies. 8104606
@jezdez jezdez Comment out 2.5 for now as it's not enabled upstream yet. 900d95a
@jezdez jezdez Re-enabled 2.5 in the experimental travis config file. c9d86c5
@pnasrat pnasrat Use 3.x compatible version of pip-test-package.
Tag pushed so make this less brittle.
ba410ac
Paul Nasrat Merge pull request #475 from pnasrat/fix_flaky_nose
Use 3.x compatible version of pip-test-package.
20b618c
Oren Held Adapt unit to SI standards: Kb/Mb -> KB/MB
Lowercase b means 'bit' while uppercase means 'byte':
http://en.wikipedia.org/wiki/Megabyte
eb096fb
@carljm carljm Merge pull request #477 from orenhe/develop
Adapt unit to SI standards: Kb/Mb -> KB/MB
b072a9a
@carljm carljm More detail in changelog about how to replace -E. 00a2234
Thomas Fenzl fixes #427 in own branch 2c0ac18
Thomas Fenzl Authors file... d5e2509
@carljm carljm Merge pull request #481 from anotherthomas/req_file_schema
Clearer error message on bad VCS URL. Thanks Thomas Fenzl.
d8cfa87
@carljm carljm No .format() formatting yet. 4b6872d
@carljm carljm Add changelog for #427 fix. 417fae4
@carljm carljm Fix upgrade of VCS requirement with otherwise nonexistent egg. Fixes #… f887aa6
@pnasrat pnasrat Issue #482 search raises exception.
Handle pypi results for packages with no ordering.

TESTED=2.4.6 2.7.1 3.2.2
2606cf3
Paul Nasrat Merge pull request #488 from pnasrat/482-no-ordering
Issue #482 search raises exception.
87c719c
@carljm carljm Fixed #487 - don't check for best-version-already-installed with expl…
…icit-URL requirements when upgrading.
19e1eab
@carljm carljm Fixed a test that was failing intermittently due to pyc file race con…
…ditions.
db3eadd
@carljm carljm Add a __main__.py to enable 'python -m pip' on Python 2.7+. Thanks Al…
…exey Luchko.
b883aa6
@carljm carljm Add news entry for __main__.py. dfe39ed
@tgecho tgecho Merge branch 'refs/heads/develop' into feature/record-download-info 488b29d
@tgecho tgecho Cleaned up info_file tests based on discussion in pypa#453 efaf106
@tgecho tgecho Add branch to travis ci 9990c26
@tgecho tgecho Consolidated some of the testing code. 5c6c0f9
@tgecho tgecho Remove iteritems() for py3 compatibility. 79b6114
Owner
dstufft commented Apr 10, 2012

oh no dude, it's completely fine :) I haven't had a lot of time and what free time I have had has been sucked up by working on https://crate.io/

I can try and take a look through these, but if you want to take over this more power to you.

On Tuesday, April 10, 2012 at 6:08 PM, tgecho wrote:

Hey! I pushed forward on your pull request as far as I could. I've tried to address the concerns raised in the original (hardcoded paths and other test issues). I also merged in upstream develop. Here's a compare of the actual changes I've made: tgecho/pip@488b29d...feature/record-download-info

I'm a little puzzled as to why the tests failed so spectacularly in python 3, but I started with replacing the iteritems() and the errors all seemed to go away. I still can't wrap my head around what is breaking with bundling, and there's another unrelated error in test_editable_git_upgrade (only in 2.5/2.6) that I don't get either.

Anyway, it's progress. If you don't have time to continue right now, I'll see what I can do. I figured I'd send the code to you first before stepping on your toes upstream. :)

http://travis-ci.org/#!/tgecho/pip/builds/1061109

You can merge this Pull Request by running:

git pull https://github.com/tgecho/pip feature/record-download-info

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • use dummy_threading when the threading module is not present.
  • Merge pull request #455 from dengzhp/develop
  • Bumped version to 1.1 and updated changelog slightly.
  • Merge branch 'release/1.1' into develop
  • Bumped to post1.
  • Add reference to --environment along with -E in changelog; refs #460.
  • Added experimental config file for Travis CI.
  • Merge branch 'develop' of github.com (http://github.com):pypa/pip into develop
  • One character change to trigger Travis build.
  • Remove git-core from list of dependencies.
  • Comment out 2.5 for now as it's not enabled upstream yet.
  • Re-enabled 2.5 in the experimental travis config file.
  • Use 3.x compatible version of pip-test-package.
  • Merge pull request #475 from pnasrat/fix_flaky_nose
  • Adapt unit to SI standards: Kb/Mb -> KB/MB
  • Merge pull request #477 from orenhe/develop
  • More detail in changelog about how to replace -E.
  • fixes #427 in own branch
  • Authors file...
  • Merge pull request #481 from anotherthomas/req_file_schema
  • No .format() formatting yet.
  • Add changelog for #427 fix.
  • Fix upgrade of VCS requirement with otherwise nonexistent egg. Fixes #486.
  • Issue #482 search raises exception.
  • Merge pull request #488 from pnasrat/482-no-ordering
  • Fixed #487 - don't check for best-version-already-installed with explicit-URL requirements when upgrading.
  • Fixed a test that was failing intermittently due to pyc file race conditions.
  • Add a main.py to enable 'python -m pip' on Python 2.7+. Thanks Alexey Luchko.
  • Add news entry for main.py.
  • Merge branch 'refs/heads/develop' into feature/record-download-info
  • Cleaned up info_file tests based on discussion in pypa#453
  • Add branch to travis ci
  • Consolidated some of the testing code.
  • Remove iteritems() for py3 compatibility.

-- File Changes --

A .travis.yml (17)
M AUTHORS.txt (1)
A main.py (7)
M docs/conf.py (2)
M docs/news.txt (32)
M pip/commands/search.py (2)
M pip/index.py (5)
M pip/req.py (14)
M pip/util.py (6)
M pip/vcs/init.py (5)
M setup.py (2)
M tests/test_info_file.py (64)
M tests/test_pip.py (1)
M tests/test_requirements.py (11)
M tests/test_search.py (12)
M tests/test_upgrade.py (20)
M tests/test_vcs_backends.py (8)

-- Patch Links --

https://github.com/dstufft/pip/pull/1.patch
https://github.com/dstufft/pip/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

tgecho commented Apr 11, 2012

Ok, I'll see if I can find time to hammer out that odd test failure and push it up for them to help with the bundling stuff. I'll ping you if I have any questions.

Crate.io looks pretty awesome by the way!

Owner
dstufft commented Apr 11, 2012

For what it's worth I think i've had that git test fail randomly on even fresh checkouts.

And thanks a lot :)

On Tuesday, April 10, 2012 at 8:26 PM, tgecho wrote:

Ok, I'll see if I can find time to hammer out that odd test failure and push it up for them to help with the bundling stuff. I'll ping you if I have any questions.

Crate.io (http://Crate.io) looks pretty awesome by the way!


Reply to this email directly or view it on GitHub:
#1 (comment)

@dstufft dstufft pushed a commit that referenced this pull request May 18, 2013
@TC01 TC01 Fixed commit #1 to actually work 5442218
@dstufft dstufft closed this Nov 19, 2014
@dstufft dstufft pushed a commit that referenced this pull request Apr 30, 2015
@qwcode qwcode refactor the requirements file parsing
two major changes:

1) re-use the optparse options in pip.cmdoptions instead of maintaining
   a custom parser

2) as a result of #1, simplify the call stack
    from:  parse_requirements -> parse_content -> parse_line
      to:  parse_requirements -> process_line

beyond #1/#2, minor cosmetics and adjusting the tests to match
764e468
@dstufft dstufft pushed a commit that referenced this pull request Apr 30, 2015
@qwcode qwcode 1) parse with defaults set as they are naturally (vs forcing to None)
   and adjust the logic to match; the result is simpler.
2) Due to #1, we can remove some hairy "format_control" hacks
3) Due to #1, we have to relax the parsing and allow:
   - multiple options per line
   - any supported option on a line with a requirement (not just
     --install-option/--global-option, although they are the only
     options that are passed into a requirement)
7c83f8d
@dstufft dstufft pushed a commit that referenced this pull request Nov 5, 2015
@natefoo natefoo 1. Provide a fallback mechanism for determining ABI flags if config vars
   are unavailable, but issue a warning if this is used.
2. Explicitly handle the case where the unicode detection finds wide
   unicode but this is a 3.3+ build (necessary due to #1)
3. Fix tests broken due to #2.
63d239f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment