Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to parse file-level options #2

Open
awalterschulze opened this issue May 18, 2015 · 4 comments
Open

fails to parse file-level options #2

awalterschulze opened this issue May 18, 2015 · 4 comments

Comments

@awalterschulze
Copy link

It seems like it is still struggling to parse extensions.

$ gotoc puddingmilkshake.proto
puddingmilkshake.proto:7: got "gogoproto.populate_all", want "="

It should probably give some import error about not being able to find the import for
import "github.com/gogo/protobuf/gogoproto/gogo.proto";

Here is a link to the file.
https://github.com/katydid/katydid/blob/master/asm/test/puddingmilkshake.proto

@dsymonds
Copy link
Owner

That's not an extension. It's a file-level option. Yes, that isn't parsed yet.

@dsymonds dsymonds changed the title extensions fails to parse file-level options May 18, 2015
@awalterschulze
Copy link
Author

Ok sorry, I think of it as an extension on the file options.

@dsymonds
Copy link
Owner

That's fine. It's precision terminology because these are all overlapping concepts. Custom options are implemented as extensions to specific descriptor messages.

@tv42
Copy link

tv42 commented Dec 27, 2019

The really nasty consequence of this is that gotoc can't set the generated Go package name.

option go_package = "foo";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants