New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock resets to white colour when time is over #1

Closed
franziskas opened this Issue Jan 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@franziskas

franziskas commented Jan 19, 2017

Not sure if bug or feature, if the time has expired, the clock turns red, starts counting down from 2:00 again and then it turns white after a couple of seconds (see screenshots).
screen shot 2017-01-19 at 15 55 45

screen shot 2017-01-19 at 15 55 51

screen shot 2017-01-19 at 15 55 57

@dtanzer

This comment has been minimized.

Show comment
Hide comment
@dtanzer

dtanzer Jan 19, 2017

Owner

You never know with legacy code, but you have to preserve the user visible behaviour ;)

(TBH, I designed this as a feature back when I wrote it, because I found it to be annoying if it stays red. But in a real legacy code situation, you probably could not talk to the original developer or business analyst)

Owner

dtanzer commented Jan 19, 2017

You never know with legacy code, but you have to preserve the user visible behaviour ;)

(TBH, I designed this as a feature back when I wrote it, because I found it to be annoying if it stays red. But in a real legacy code situation, you probably could not talk to the original developer or business analyst)

@franziskas

This comment has been minimized.

Show comment
Hide comment
@franziskas

franziskas Jan 19, 2017

@dtanzer I wasn't planning on changing the behaviour, don't worry. This report is outside the exercise, as I want to do a pure refactoring (without behaviour changes) if possible.

franziskas commented Jan 19, 2017

@dtanzer I wasn't planning on changing the behaviour, don't worry. This report is outside the exercise, as I want to do a pure refactoring (without behaviour changes) if possible.

@dtanzer dtanzer closed this Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment