From a3bc1fa958aeca8d1cbc0bad8f1a026796d39b7a Mon Sep 17 00:00:00 2001
From: John Halley Gotway <johnhg@ucar.edu>
Date: Mon, 13 May 2024 12:15:12 -0600
Subject: [PATCH] Per #2883, move initialization inside the same loop to
 resolve SonarQube issues.

---
 src/tools/core/pcp_combine/pcp_combine.cc | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/tools/core/pcp_combine/pcp_combine.cc b/src/tools/core/pcp_combine/pcp_combine.cc
index 8a54da6a1..ee1f59a0a 100644
--- a/src/tools/core/pcp_combine/pcp_combine.cc
+++ b/src/tools/core/pcp_combine/pcp_combine.cc
@@ -592,19 +592,16 @@ void sum_data_files(Grid & grid, DataPlane & plane) {
         << sec_to_hhmmss(out_accum) << ".\n";
 
    //
-   // Compute the valid times for the precipitation files
-   // to be found.
+   // Search for each file time.
    //
-   for(i=0; i<n_files; i++) {
+   for(i=0, n_vld=0; i<n_files; i++) {
+
+      //
+      // Define the target valid time and initialize.
+      //
       pcp_times[i] = valid_time - i*in_accum;
       pcp_recs[i] = -1;
       pcp_files[i] = "";
-   }
-
-   //
-   // Search for each file time.
-   //
-   for(i=0, n_vld=0; i<n_files; i++) {
 
       //
       // Search in each directory for the current file time.