Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1789 main_v10.0 docs #1790

Merged
merged 1 commit into from
May 12, 2021
Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    None needed, just doc update.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review updated plot_point_obs documentation.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [5/12/21].

    Should only take 1 minute.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes for the removal of duplicate information and approve this pull request.

@JohnHalleyGotway JohnHalleyGotway merged commit 3becf7e into main_v10.0 May 12, 2021
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_1789_main_v10.0_docs branch May 12, 2021 17:28
JohnHalleyGotway added a commit that referenced this pull request Jul 6, 2021
* Per #1789, remove duplicate plot_point_obs configuration section. (#1790)

* Per #1798, fix up the read_tmpe_dataplane.py script to handle a grid string or dictionary. (#1799)

* Github Issue #1801: Comment out code that checks for BEST track to support extra-tropical cyclone tracks not verified against BEST tracks.

* Bugfix 1395 main_v10.0 comp script (#1796)

* Updating compile script and associated config files for met-10.0.0

* Removing old config files

* install_met_env.het

* Updated orion file

* Added stampede2 config file

* Adding modulefiles for various machines

* Feature main_v10.0 bugfix_checklist (#1803)

* Recommended updates to clarify the use of projects and milestones for bugfixes.

* Making details consistent across all issue templates.

* Per met-help question (https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=99964) clarify the description of the obs_thresh option.

* Update README.md

Adding text for GitHub Discussions

* changed non-unicode apostrophe and fixed typo in URL (#1813)

* Correct formatting errors in release notes.

* #1817 Added to_north argument at two_to_one()

* #1817 Calls two_to_one() with false for the third argument, if latitude moves north to south

* #1508 checking stat() methoid returns no error before looking at FILE flag

Co-authored-by: bikegeek <minnawin@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Plot-Point-Obs documentation to remove the duplicate configuration section.
2 participants