Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for setting obs_quality_inc/exc in PointStat #1213

Closed
21 tasks
georgemccabe opened this issue Oct 20, 2021 · 0 comments · Fixed by #1260
Closed
21 tasks

Added support for setting obs_quality_inc/exc in PointStat #1213

georgemccabe opened this issue Oct 20, 2021 · 0 comments · Fixed by #1260
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Added in dtcenter/MET#1858

Describe the Enhancement

Provide a description of the enhancement request here.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 20, 2021
@georgemccabe georgemccabe self-assigned this Oct 20, 2021
@georgemccabe georgemccabe added this to To do in METplus-4.1.0-beta4 (11/16/21) via automation Oct 20, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Oct 20, 2021
@georgemccabe georgemccabe added required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 20, 2021
georgemccabe added a commit that referenced this issue Nov 12, 2021
…c in PointStat and EnsembleStat. POINT_STAT_OBS_QUALITY will now set obs_quality_inc if POINT_STAT_OBS_QUALITY_[INC/INCLUDE] are not set. Added documentation and unit tests for each new setting. Added commented out example in each basic use case config file.
@georgemccabe georgemccabe linked a pull request Nov 12, 2021 that will close this issue
12 tasks
@georgemccabe georgemccabe moved this from To do to Pull Request Review in METplus-4.1.0-beta4 (11/16/21) Nov 12, 2021
METplus-4.1.0-beta4 (11/16/21) automation moved this from Pull Request Review to Done Nov 15, 2021
@TaraJensen TaraJensen added requestor: UK Met Office United Kingdom Met Office and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants