New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `pretty` mod or `write_to_ryu_buffer` function public? #5

Closed
Alexhuszagh opened this Issue Nov 10, 2018 · 3 comments

Comments

2 participants
@Alexhuszagh
Copy link

Alexhuszagh commented Nov 10, 2018

I already have an intermediate stack buffer, but would like to use the pretty formatting via pretty:{f2s_buffered_n, d2s_buffered_n}. Right now, this is publicly exposed via Float::write_to_ryu_buffer, however, this is very clearly not a public API and likely to change.

Would you be willing to make any guarantees about the write_to_ryu_buffer method in the Float trait, either in the current form, or some new form, or expose the pretty:{f2s_buffered_n, d2s_buffered_n} functions publicly?

@Alexhuszagh Alexhuszagh changed the title Make `write_to_ryu_buffer` or some form public? Make `pretty` mod or `write_to_ryu_buffer` function public? Nov 10, 2018

@dtolnay

This comment has been minimized.

Copy link
Owner

dtolnay commented Nov 10, 2018

How's this? #6

@Alexhuszagh

This comment has been minimized.

Copy link

Alexhuszagh commented Nov 10, 2018

@dtolnay Excellent, thank you!

@dtolnay dtolnay closed this in #6 Nov 10, 2018

@dtolnay

This comment has been minimized.

Copy link
Owner

dtolnay commented Nov 10, 2018

Okay. :) I published 0.2.7 with those functions exposed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment