Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libz blitz/use question mark instead of unwrap in examples #160

Merged
merged 5 commits into from
Dec 17, 2017
Merged

Libz blitz/use question mark instead of unwrap in examples #160

merged 5 commits into from
Dec 17, 2017

Conversation

opilar
Copy link
Contributor

@opilar opilar commented Nov 24, 2017

Rebased #144
Resolves #129

@KodrAus
Copy link

KodrAus commented Nov 24, 2017

Thanks for this @opilar 👍

@apopiak
Copy link

apopiak commented Dec 17, 2017

This is done and will be merged, right? (Was thinking about picking this up)

@apopiak apopiak mentioned this pull request Dec 17, 2017
Closed
@opilar
Copy link
Contributor Author

opilar commented Dec 17, 2017

@apopiak yes, it's done. Waiting to be merged.

steveklabnik
steveklabnik approved these changes Dec 17, 2017
View reviewed changes
Copy link
Contributor

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Sorry, it's been a hectic month, and I've been focusing on semver-parser over semver lately. This looks great; thank you so much!

@steveklabnik steveklabnik merged commit 02162c0 into dtolnay:master Dec 17, 2017
@opilar
Copy link
Contributor Author

opilar commented Dec 17, 2017

@steveklabnik thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

@KodrAus KodrAus KodrAus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@opilar @KodrAus @apopiak @steveklabnik @muzikmoe