Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #[from] on an Option field #147

merged 2 commits into from Aug 28, 2021

Support #[from] on an Option field #147

merged 2 commits into from Aug 28, 2021


Copy link

@dtolnay dtolnay commented Aug 28, 2021

This allows ? to work with error types that only sometimes have a source (as seen in #1).

use std::io;
use thiserror::Error;

#[derive(Error, Debug)]
pub struct Error {
    source: Option<io::Error>,

fn main() -> Result<(), Error> {
    io::copy(&mut io::empty(), &mut io::sink())?;

@dtolnay dtolnay merged commit 9af5265 into master Aug 28, 2021
12 checks passed
@dtolnay dtolnay deleted the optionfrom branch Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant