From cffba01e12661ab91252be03a07567db7d1f0f29 Mon Sep 17 00:00:00 2001 From: Dima Date: Fri, 4 Oct 2019 08:12:04 +0200 Subject: [PATCH] go_1_12: disable flakey TestGcSys test (PR #70368) In our tests we have experienced failures of this test, but it was otherwise not reproducible so far. A backported upstream fix did not alleviate the issue either, so disabling seems workable for now. --- pkgs/development/compilers/go/1.12.nix | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkgs/development/compilers/go/1.12.nix b/pkgs/development/compilers/go/1.12.nix index 7a6c0b041fc495..a1476c36abba78 100644 --- a/pkgs/development/compilers/go/1.12.nix +++ b/pkgs/development/compilers/go/1.12.nix @@ -96,6 +96,12 @@ stdenv.mkDerivation rec { # Disable cgo lookup tests not works, they depend on resolver rm src/net/cgo_unix_test.go + # Disable TestGcSys because it's flakey in our tests, but the failure is not + # reproducible by multiple people in other environments. + # See https://github.com/NixOS/nixpkgs/issues/68361#issuecomment-537849272 and following + # NOTE: Try re-enabling for releases newer than 1.12.9 + sed -i '/TestGcSys/areturn' src/runtime/gc_test.go + '' + optionalString stdenv.isLinux '' sed -i 's,/usr/share/zoneinfo/,${tzdata}/share/zoneinfo/,' src/time/zoneinfo_unix.go '' + optionalString stdenv.isAarch32 ''