Permalink
Browse files

miDbe window priv priv is pre-allocated, don't use dixSetPrivate (bug…

… 28639)

miDbeInit pre-allocates space in each DBE window private private for a
MiDbeWindowPrivPrivRec. miDbeAllocBackBufferName used the
pre-allocated space correctly (simply fetching it instead of
allocating a new piece of memory). However, it then called
dixSetPrivate anyways, which isn't necessary, and (in the new
dixPrivate world) causes an assert failure.

Signed-off-by: Keith Packard <keithp@keithp.com>
Tested-by: Magnus Kessler <Magnus.Kessler@gmx.net>
Reviewed-by: Magnus Kessler <Magnus.Kessler@gmx.net>
  • Loading branch information...
keith-packard committed Jul 1, 2010
1 parent a94cb40 commit 9f0b193acdc29e491b6245390cf9f53b5222e6d3
Showing with 0 additions and 6 deletions.
  1. +0 −6 dbe/midbe.c
View
@@ -202,12 +202,6 @@ miDbeAllocBackBufferName(WindowPtr pWin, XID bufId, int swapAction)
return (rc == Success) ? BadAlloc : rc;
}
-
- /* Attach the priv priv to the priv. */
- dixSetPrivate(&pDbeWindowPriv->devPrivates, miDbeWindowPrivPrivKey,
- pDbeWindowPrivPriv);
-
-
/* Clear the back buffer. */
pGC = GetScratchGC(pWin->drawable.depth, pWin->drawable.pScreen);
if ((*pDbeScreenPriv->SetupBackgroundPainter)(pWin, pGC))

0 comments on commit 9f0b193

Please sign in to comment.