Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial thoughts #1

Open
chris1610 opened this issue Jul 18, 2019 · 15 comments

Comments

@chris1610
Copy link
Collaborator

commented Jul 18, 2019

I like the article. It is coming together nicely. Good job!

You can add a brief sentence or two that describes yourself and links back to your blog if you'd like. I will probably add a sentence of two about this being a guest post.

Also, you may want to discuss briefly anything related to potential security considerations of placing these files on a cloud server or running from a VPS like Digital Ocean.

Do you want me to create a flow diagram based on your image? I have an account with Lucid Chart and would be happy to do so if you want me to.

Finally, the article is getting kind of long. I wonder if we should split it into two posts. What do you think about that? I'm not 100% sure we need to but wanted to throw the idea out there.

Thanks again. It's looking really good.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 19, 2019

Hi Chris, not sure why I did not receive a notification on this issue.. Had I seen it I wouldn't have emailed you.

Short Notes:

"You can add a brief sentence or two that describes yourself and links back to your blog if you'd like. I will probably add a sentence of two about this being a guest post."
Will do.

"Also, you may want to discuss briefly anything related to potential security considerations of placing these files on a cloud server or running from a VPS like Digital Ocean."
Great idea. I will add a note.

"Do you want me to create a flow diagram based on your image? I have an account with Lucid Chart and would be happy to do so if you want me to"
I think that would be a good idea. I think trying to understand the concept and my bad handwriting at the same time, can be a pain.

Longer considerations

I agree that it's getting too long. Maybe a 2 part article could make more sense. But I am still uncertain about the structure. As it is now:

  • I explain different concepts one by one
  • I bring it all together with the final part

Not sure if this is the right way to go..

What do you think a good structure would be?

Thanks for the valuable feedback..

@chris1610

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 20, 2019

I added the flow diagram. Let me know if you think it's ok or want any additional changes to it.

As far as breaking it up into two parts, I think it is ok to break it up at the workflow step. That section is a little bit long but maybe we shorten it by not including the full code example in section 5. We can link to a github location that includes the full code sample.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 20, 2019

Thanks so much for adding the diagram, it looks really good.

I have broken the post into two parts: part 1 and part 2.

I corrected/reviewed the following:

  • added a small paragraph about me here
  • added a note about security to part 2 right here.

I reviewed part 1 including the structure, files, and spelling, and I think it is ready for a final review from your side.

Going to review part 2 right now, and will write here when that is done.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 20, 2019

Draft of part 2 also ready for review.

Let me know if you would like me to remove the twitter screenshot in the final thoughts part for privacy reasons. Thought it could be fun, but we all hate spam..

@chris1610

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 20, 2019

I am close to posting a draft for you to review. Do you have an image you would like me to use in the header? You can look at any of my posts and see what I typically do.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 20, 2019

What about an old factory theme? Somewhat related to automation..

32637661426_58671d8c5d_k
Hartmann_Maschinenhalle_1868_(01)
8111589981_aa331e30dd_b

@chris1610

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 20, 2019

Ok. I have posted a draft here for us to review - https://pbpython.com/drafts/papermil-rclone-report-1.html

Please don't share it yet. Once we are good, I'll post it on the front page and share it...

Also, I tend to find that I get the most traffic when I post it on Monday mornings (US Central Timezone). I also think it is best to post the first article then follow up in about a week with the second article. That should maximize the traffic.

Anyway, take a look and let me know if there are any issues.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 20, 2019

Thanks for creating the draft, here are just a couple of notes:

  • should we change the headline after the Introduction to only be: Part 1: Tool Roundup ?
  • Can we make the figure of the dataframe print a bit smaller? the one after "When printing the data dataframe, we get the following:"
  • After the plot, the jupyter notebook link is broken, should be: https://github.com/duarteocarmo/automation-post/blob/master/src/sales_january.ipynb I will make the repo public once we have an approved draft.
  • maybe also add the github repo link to the intro in a paragraph after the "python 3.7" note..

Sorry for the late reply - its PM here and I was getting dinner 😄

@chris1610

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 21, 2019

I have made the changes you mentioned. I also changed the overall title to remove rclone since we don't cover it in this article.

Take a look at the rest of the links and everything else and let me know if you have any other concerns.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 21, 2019

Is it the same link? I don’t think the draft was updated..

@chris1610

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 21, 2019

Try it now. I had to force the cache to invalidate. Make sure to force a reload on your browser too.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 21, 2019

Huum.. Still not working, I tried a different browser, private mode, force reload and appending "?noCache=True"

@chris1610

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 21, 2019

Very odd. The joys of the cloud I guess.

I am attaching a pdf version until we figure out what's going on.

Automated Report Generation with Papermill_ Part 1 - Practical Business Python.pdf

@chris1610

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 21, 2019

The PDF version shows the links but they don't display on the website so don't worry about that aspect of the PDF.

@duarteocarmo

This comment has been minimized.

Copy link
Owner

commented Jul 21, 2019

Looking good! I think we are ready to go. Made this repo public as well 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.