Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:pixiu hashing need this func #110

Merged
merged 1 commit into from Dec 16, 2022
Merged

Conversation

baerwang
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

Codecov Report

Merging #110 (e579e37) into master (64a6483) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   73.62%   73.55%   -0.07%     
==========================================
  Files          51       51              
  Lines        4959     4961       +2     
==========================================
- Hits         3651     3649       -2     
- Misses       1074     1078       +4     
  Partials      234      234              
Impacted Files Coverage Δ
hash/consistent/consistent.go 81.17% <0.00%> (-0.69%) ⬇️
time/timer.go 77.85% <0.00%> (-0.68%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@baerwang baerwang merged commit 4c45e16 into dubbogo:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants