Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clap to 3.1.0 #235

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Update clap to 3.1.0 #235

merged 2 commits into from
Feb 17, 2022

Conversation

blyxxyz
Copy link
Collaborator

@blyxxyz blyxxyz commented Feb 16, 2022

  • Deal with the deprecations
  • Remove the error.info hack
  • Fix a clippy warning that's showing up on nightly

@ducaale
Copy link
Owner

ducaale commented Feb 16, 2022

Can you update Clap's version in Cargo.toml?

ducaale
ducaale reviewed Feb 17, 2022
View reviewed changes
src/cli.rs Show resolved Hide resolved
@blyxxyz
Update clap to 3.1.0
78b897a 
Deal with the deprecations, and stop smuggling our own signals inside
clap's errors.
@blyxxyz
Resolve clippy::single_char_pattern lint
49ff79e 
(This lint isn't out yet.)
ducaale
ducaale approved these changes Feb 17, 2022
View reviewed changes
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ducaale ducaale merged commit 815753c into ducaale:develop Feb 17, 2022
@blyxxyz blyxxyz deleted the update-clap branch February 18, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducaale ducaale ducaale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blyxxyz @ducaale