From 4c49769596bdb65939119f21bb86a86da96fbd86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20M=C3=BChleisen?= Date: Wed, 11 Oct 2023 09:11:59 +0200 Subject: [PATCH 1/7] lets try updating curl --- .github/workflows/NodeJS.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index 6e9f7ac8..cfd6c2dc 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -126,7 +126,7 @@ jobs: if: startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb-node' name: node.js OSX runs-on: macos-latest - needs: linux-nodejs + #needs: linux-nodejs strategy: matrix: target_arch: [ x64, arm64 ] @@ -164,6 +164,15 @@ jobs: key: ${{ github.job }}-${{ matrix.target_arch }} save: ${{ ( github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb-node' ) && ( matrix.node == '19' ) }} + - name: Update curl + shell: bash + run: + which curl + brew update + brew install curl + which curl + echo $PATH + - name: Setup shell: bash run: ./scripts/node_version.sh From a4326b447713aaf15b4d201d481f20ed0291a1cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20M=C3=BChleisen?= Date: Wed, 11 Oct 2023 09:13:29 +0200 Subject: [PATCH 2/7] pipe --- .github/workflows/NodeJS.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index cfd6c2dc..01fcb6b4 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -166,7 +166,7 @@ jobs: - name: Update curl shell: bash - run: + run: | which curl brew update brew install curl From 68a46eb645ac7fc33958431505dd462ea772576e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20M=C3=BChleisen?= Date: Wed, 11 Oct 2023 09:16:22 +0200 Subject: [PATCH 3/7] grr --- .github/workflows/NodeJS.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index 01fcb6b4..a8871bd1 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -167,11 +167,8 @@ jobs: - name: Update curl shell: bash run: | + brew upgrade curl which curl - brew update - brew install curl - which curl - echo $PATH - name: Setup shell: bash From 37978c84b03ad86d72610b10de548ba5e4559b7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20M=C3=BChleisen?= Date: Wed, 11 Oct 2023 09:17:51 +0200 Subject: [PATCH 4/7] latest is installed and is broken yay --- .github/workflows/NodeJS.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index a8871bd1..8a18848c 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -167,7 +167,7 @@ jobs: - name: Update curl shell: bash run: | - brew upgrade curl + brew uninstall curl which curl - name: Setup From 0cc13b5e7650072297f5e45885da8b3ae8acef95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20M=C3=BChleisen?= Date: Wed, 11 Oct 2023 09:19:05 +0200 Subject: [PATCH 5/7] grr2 --- .github/workflows/NodeJS.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index 8a18848c..2c9356ed 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -167,7 +167,7 @@ jobs: - name: Update curl shell: bash run: | - brew uninstall curl + brew uninstall --ignore-dependencies curl which curl - name: Setup From d6901bc3509667b46107ec7cd023052b08cd2773 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20M=C3=BChleisen?= Date: Wed, 11 Oct 2023 09:26:10 +0200 Subject: [PATCH 6/7] fix_comment --- .github/workflows/NodeJS.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index 2c9356ed..c29274e4 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -164,7 +164,7 @@ jobs: key: ${{ github.job }}-${{ matrix.target_arch }} save: ${{ ( github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb-node' ) && ( matrix.node == '19' ) }} - - name: Update curl + - name: Downgrade curl # fixes a bug with the brew curl that lead to failed downloads shell: bash run: | brew uninstall --ignore-dependencies curl From 49bce5788944bd2000d065e3480291c635b4dc7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20M=C3=BChleisen?= Date: Wed, 11 Oct 2023 09:26:59 +0200 Subject: [PATCH 7/7] re-add dep --- .github/workflows/NodeJS.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index c29274e4..c7c1e196 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -126,7 +126,7 @@ jobs: if: startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb-node' name: node.js OSX runs-on: macos-latest - #needs: linux-nodejs + needs: linux-nodejs strategy: matrix: target_arch: [ x64, arm64 ]