Conversation
auto-merge was automatically disabled
January 21, 2025 06:45
Pull request was converted to draft
krlmlr
changed the title
krlmlr
force-pushed
the
f-tether
branch
5 times, most recently
from
5d5c3da to
4c3757d
Compare
krlmlr
added a commit
that referenced
this pull request
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this is to support automatic materialization up to a specific threshold (number of rows or number of cells). Is this perhaps built into the DuckDB library?
For review, the crucial part is https://github.com/duckdb/duckdb-r/pull/1017/files#diff-126b595d21fec2ecd861c9c0dbdb1434973d14eabf3fd0e16339e41070d74410R174-R176 : We add a limit relation with the maximum number of rows that we allow, plus one. If the result is larger, we throw an error.