fix: Support fractional seconds in TIME and INTERVAL data#1109
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of fractional seconds for TIME and INTERVAL data types by adjusting the conversion logic and updating the accompanying test snapshots.
- Update snapshot expected interval value in tests/testthat/_snaps/types.md.
- Add explicit double casts in src/transform.cpp to ensure fractional seconds are computed correctly.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/testthat/_snaps/types.md | Refreshes the expected $interval output to reflect the fractional fix. |
| src/transform.cpp | Introduces explicit double casts in TIME and INTERVAL conversion logic. |
Files not reviewed (1)
- tests/testthat/test-timestamp.R: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.