feat: Add dbConnect(array = "none"), pass array = "matrix" to enable conversion of array columns#1125
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
===========================================
- Coverage 63.61% 51.21% -12.40%
===========================================
Files 123 146 +23
Lines 5266 9920 +4654
===========================================
+ Hits 3350 5081 +1731
- Misses 1916 4839 +2923 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Seems like the 'arrow' package is not available on R 4.1: |
krlmlr
left a comment
There was a problem hiding this comment.
Thanks. The R 4.1 check failures are on me.
Do you think it's useful to split this into two PRs, and start with a refactoring PR that replaces integer64 with convert_opts everywhere? This would be easier to reason about later. I'm not sure if it's really worth investing that time now -- we can always do it after the fact if needed.
| config = list(), | ||
| bigint = "numeric" | ||
| bigint = "numeric", | ||
| array = "none" |
There was a problem hiding this comment.
I don't think bigint belongs here, this should be deprecated at some point. Let's not add "array" here. Should have been clearer about that in the code, add a comment to that effect now?
There was a problem hiding this comment.
I'm mistaken, this is where array = "none" belongs. For some reason I thought this is the duckdb() function.
|
The PR is fine as it is. Don't worry about it. |
dbConnect(array = "none"), pass array = "matrix" to enable conversion of array columns
|
Thanks! |
No description provided.