Skip to content

feat: Add dbConnect(array = "none"), pass array = "matrix" to enable conversion of array columns#1125

Merged
krlmlr merged 3 commits into
duckdb:mainfrom
joakimlinde:feature/array-convert-opts
Apr 27, 2025
Merged

feat: Add dbConnect(array = "none"), pass array = "matrix" to enable conversion of array columns#1125
krlmlr merged 3 commits into
duckdb:mainfrom
joakimlinde:feature/array-convert-opts

Conversation

@joakimlinde
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.21%. Comparing base (5c88c6f) to head (98a4bd9).
Report is 1495 commits behind head on main.

Files with missing lines Patch % Lines
src/transform.cpp 92.85% 2 Missing ⚠️
src/convert.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1125       +/-   ##
===========================================
- Coverage   63.61%   51.21%   -12.40%     
===========================================
  Files         123      146       +23     
  Lines        5266     9920     +4654     
===========================================
+ Hits         3350     5081     +1731     
- Misses       1916     4839     +2923     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joakimlinde
Copy link
Copy Markdown
Contributor Author

Seems like the 'arrow' package is not available on R 4.1: Package suggested but not available for checking: ‘arrow’

Copy link
Copy Markdown
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The R 4.1 check failures are on me.

Do you think it's useful to split this into two PRs, and start with a refactoring PR that replaces integer64 with convert_opts everywhere? This would be easier to reason about later. I'm not sure if it's really worth investing that time now -- we can always do it after the fact if needed.

config = list(),
bigint = "numeric"
bigint = "numeric",
array = "none"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think bigint belongs here, this should be deprecated at some point. Let's not add "array" here. Should have been clearer about that in the code, add a comment to that effect now?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mistaken, this is where array = "none" belongs. For some reason I thought this is the duckdb() function.

@joakimlinde
Copy link
Copy Markdown
Contributor Author

The PR is fine as it is. Don't worry about it.

@krlmlr krlmlr changed the title Add connection convert option for arrays feat: Add dbConnect(array = "none"), pass array = "matrix" to enable conversion of array columns Apr 27, 2025
@krlmlr krlmlr merged commit c35ac85 into duckdb:main Apr 27, 2025
1 of 2 checks passed
@krlmlr
Copy link
Copy Markdown
Collaborator

krlmlr commented Apr 27, 2025

Thanks!

@joakimlinde joakimlinde deleted the feature/array-convert-opts branch July 24, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants