Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 7, 2025

This PR replaces the minimal and incorrect copilot instructions file with comprehensive, validated instructions for working with the duckdb-r repository. The previous file incorrectly referenced "dm Package" instead of duckdb-r and provided no useful guidance.

Key Improvements

Validated Commands and Timing: All build and test commands have been executed and timed to provide accurate expectations:

  • First-time build: 10-15 minutes (validated at 13 minutes with parallel compilation)
  • Subsequent builds: ~3 seconds (with cache)
  • Full test suite: ~45 seconds (5800+ tests with 1 expected failure)

Critical Timeout Warnings: Added explicit "NEVER CANCEL" warnings with specific timeout values (30+ minutes for builds, 5+ minutes for tests) to prevent premature cancellation of long-running operations.

Manual Validation Scenarios: Included complete end-to-end testing scenarios that agents should run after making changes:

library(duckdb)
con <- dbConnect(duckdb())
dbExecute(con, "CREATE TABLE test (id INTEGER, name VARCHAR)")  
dbExecute(con, "INSERT INTO test VALUES (1, 'Alice'), (2, 'Bob')")
result <- dbGetQuery(con, "SELECT * FROM test ORDER BY id")
print(result)
dbDisconnect(con, shutdown=TRUE)

Repository Structure Guidance: Documented the layout of 1700+ C++ files, 40+ test files, and key directories with clear guidance on what should and shouldn't be modified.

System Dependencies: Provided exact installation commands for R, build tools, and optional formatting dependencies.

Expected Issues: Documented known formatting differences and expected test failures to avoid confusion.

Updated CLAUDE.md: Enhanced the existing operational instructions file with the same comprehensive information, making it consistent with the GitHub Copilot instructions and providing detailed guidance for developers working on the repository.

The instructions follow the firm directive requirement to "always reference these instructions first and fallback to search or bash commands only when you encounter unexpected information that does not match the info here."

Fixes #1483.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot AI changed the title [WIP] ✨ Set up Copilot instructions Create comprehensive GitHub Copilot instructions for duckdb-r package Sep 7, 2025
Copilot AI requested a review from krlmlr September 7, 2025 16:35
Copilot finished work on behalf of krlmlr September 7, 2025 16:35
@krlmlr
Copy link
Collaborator

krlmlr commented Sep 7, 2025

@copilot: Update CLAUDE.md with these instructions.

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Sep 7, 2025

@copilot: Update CLAUDE.md with these instructions.

Updated CLAUDE.md with the comprehensive instructions from the GitHub Copilot instructions file. The file now includes validated commands with timing, critical timeout warnings, manual validation scenarios, repository structure guidance, and all the detailed information. Commit ed171b1.

Copilot AI changed the title Create comprehensive GitHub Copilot instructions for duckdb-r package Create comprehensive GitHub Copilot instructions and update CLAUDE.md for duckdb-r package Sep 7, 2025
Copilot finished work on behalf of krlmlr September 7, 2025 17:00
@krlmlr krlmlr changed the title Create comprehensive GitHub Copilot instructions and update CLAUDE.md for duckdb-r package chore: Add AI instructions Sep 7, 2025
@krlmlr krlmlr marked this pull request as ready for review September 7, 2025 17:29
@krlmlr krlmlr enabled auto-merge September 7, 2025 17:29
@krlmlr krlmlr merged commit 4b0cbc5 into main Sep 7, 2025
5 checks passed
@krlmlr krlmlr deleted the copilot/fix-1483 branch September 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Set up Copilot instructions

2 participants