Repository navigation
fix: Fix translation of quantile() to use DuckDB's native QUANTILE_CONT() syntax - #1735
Merged
Merged
Conversation
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect quantile translation in lazy table
Fix quantile translation to use DuckDB native QUANTILE_CONT syntax
Nov 26, 2025
quantile() to use DuckDB's native QUANTILE_CONT() syntax
krlmlr
marked this pull request as ready for review
November 26, 2025 14:27
krlmlr
enabled auto-merge (squash)
November 26, 2025 14:27
krlmlr
added a commit
that referenced
this pull request
Feb 15, 2026
duckdb 1.4.3 - Update to DuckDB v1.4.3, see <https://github.com/duckdb/duckdb/releases/tag/v1.4.3> for details. - Add `str_ilike()` support (@edward-burn, #1810, #1811). - Fail with non-UTF8-encoded strings during data frame scan instead of attempting to reencode (#1795). - Avoid inclusion of raw error message in the output. - Fix translation of `quantile()` to use DuckDB's native `QUANTILE_CONT()` syntax (#1734, #1735). - Remove redundant R version checks from tests (#1815, #1816).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dbplyr
quantile()translation generatesPERCENTILE_CONT(probs) WITHIN GROUP (ORDER BY x) OVER ()which DuckDB doesn't support as a window function.Changes
quantileaggregate translation usingQUANTILE_CONT(x, probs)syntaxquantilewindow translation with properwin_over()wrappingQUANTILE_CONTto globalVariables for R CMD checkWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.r-project.org/opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -q -e options(repos~+~=~+~c(CRAN='REDACTED'));~+~install.packages(c('DBI',~+~'dbplyr',~+~'dplyr',~+~'testthat',~+~'rlang',~+~'cli',~+~'withr',~+~'brio'))(dns block)/usr/bin/curl curl -s REDACTED(dns block)/usr/bin/curl curl -I REDACTED(dns block)cran.r-project.org/opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -q -e install.packages(c('DBI',~+~'dbplyr',~+~'dplyr',~+~'testthat'),~+~repos='REDACTED')(dns block)cran.rstudio.com/opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -q -e install.packages(c('DBI',~+~'dbplyr',~+~'dplyr',~+~'testthat',~+~'rlang',~+~'cli',~+~'withr',~+~'brio'),~+~repos='REDACTED')(dns block)esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.