Skip to content

Conversation

@m-muecke
Copy link
Contributor

@m-muecke m-muecke commented Nov 6, 2023

No description provided.

@m-muecke m-muecke changed the title feat: added prod dbplyr translation feat: added prod dbplyr translation Nov 6, 2023
@krlmlr
Copy link
Collaborator

krlmlr commented Nov 8, 2023

Thanks. What would a test for this and other functionality look like?

@m-muecke
Copy link
Contributor Author

m-muecke commented Nov 8, 2023

Thanks. What would a test for this and other functionality look like?

I have added some tests for the current agg functions. What is the scope difference between the duckdb and the duckplyr package for dplyr translations, they seem to overlap.

@krlmlr
Copy link
Collaborator

krlmlr commented Nov 8, 2023

duckplyr is data frame in, data frame out, with full compatibility and fallback to dplyr if needed.

@krlmlr krlmlr changed the title feat: added prod dbplyr translation feat: Add prod() translation for dbplyr Nov 8, 2023
@krlmlr krlmlr merged commit d8c4235 into duckdb:main Nov 8, 2023
@krlmlr
Copy link
Collaborator

krlmlr commented Nov 8, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants