Conversation
krlmlr
force-pushed
the
f-xz
branch
2 times, most recently
from
46ad6a7 to
9777368
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
eitsupi
reviewed
Oct 28, 2024
Contributor
eitsupi
left a comment
eitsupi
left a comment
There was a problem hiding this comment.
I do not know if the cleanup script is the right place to do this.
Comment on lines
+46
to
+47
| ^cleanup$ | ||
| ^cleanup\.win$ |
Contributor
There was a problem hiding this comment.
Is it correct that these are here?
Collaborator
Author
There was a problem hiding this comment.
I think so, the tarball has the .xz file and doesn't need this procedure.
Collaborator
Author
There was a problem hiding this comment.
cleanup is run as part of R CMD build . in the right location at the right time. Seems legit, but 🤷 .
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
fine by me |
hannes
approved these changes
Oct 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considerably smaller, still we ship all sources. Should get us at least to duckdb 1.2.0 🤣
CC @david-cortes @eitsupi.